Skip to content

Revert "release/6.0 Upgrade Selenium Driver" #36034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2021
Merged

Revert "release/6.0 Upgrade Selenium Driver" #36034

merged 1 commit into from
Sep 1, 2021

Conversation

TanayParikh
Copy link
Contributor

Reverts #35986

Looks like it broke the quarantined tests pipeline. Timestamps of merge/failing builds line up:

image

Also reverting main: #36033

@TanayParikh TanayParikh requested a review from dougbu as a code owner September 1, 2021 16:38
@TanayParikh TanayParikh enabled auto-merge (squash) September 1, 2021 16:38
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 1, 2021
@TanayParikh TanayParikh requested a review from a team September 1, 2021 17:07
wtgodbe
wtgodbe approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. Agree that we should undo this in 6.0, but it's also worth investigating in main so it doesn't block us from upgrading in the future

@TanayParikh
Copy link
Contributor Author

but it's also worth investigating in main so it doesn't block us from upgrading in the future

Yep. Just reverting on both for now to ensure builds remain in an healthy state while we investigate the failures.

@TanayParikh TanayParikh merged commit ec2ae57 into release/6.0 Sep 1, 2021
@TanayParikh TanayParikh deleted the revert-35986-taparik/release6-0-SeleniumUpgrade branch September 1, 2021 17:55
@ghost ghost added this to the 6.0-rc2 milestone Sep 1, 2021
@TanayParikh TanayParikh mentioned this pull request Sep 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@dougbu dougbu Awaiting requested review from dougbu

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
6.0-rc2
Development

Successfully merging this pull request may close these issues.
2 participants
@TanayParikh @wtgodbe